codeant-ai-for-open-source[bot] commented on code in PR #43729:
URL: https://github.com/apache/superset/pull/43729#discussion_r3924358929
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1254,7 +1254,7 @@ export default function transformProps(
showMaxLabel,
xAxisType,
xAxisLabelRotation,
- xAxisLabelInterval,
+ xAxisLabelInterval === '0' ? 0 : xAxisLabelInterval,
Review Comment:
Yes—the “All” setting should mean ECharts receives every generated label,
not merely that the interval callback selects every tick. `hideOverlap` is a
separate post-processing step and can still remove labels when temporal ticks
are pinned.
The shared temporal-axis utility should therefore disable overlap hiding
when the normalized interval is numeric `0`, while retaining the existing
behavior for `'auto'` and positive numeric intervals:
```ts
const normalizedInterval =
xAxisLabelInterval === '0' ? 0 : xAxisLabelInterval;
const temporalAxisTickConfig = getTemporalAxisTickConfig(
temporalTickValues,
showMaxLabel,
xAxisType,
xAxisLabelRotation,
normalizedInterval,
deduplicatedFormatter,
isHorizontal,
zoomable,
);
```
Then, in `getTemporalAxisTickConfig`, set:
```ts
hideOverlap: xAxisLabelInterval !== 0,
```
(or override it to `false` specifically for the `0` case). This preserves
collision avoidance for `'auto'` and other intervals while making the “All”
option consistent in both Timeseries and MixedTimeseries. A regression test
should also cover the pinned-tick path and assert `hideOverlap === false` when
the interval is `'0'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
