sadpandajoe commented on code in PR #43729:
URL: https://github.com/apache/superset/pull/43729#discussion_r3924373567
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1254,7 +1254,7 @@ export default function transformProps(
showMaxLabel,
xAxisType,
xAxisLabelRotation,
- xAxisLabelInterval,
+ xAxisLabelInterval === '0' ? 0 : xAxisLabelInterval,
Review Comment:
For the normal temporal-axis path, this value still cannot make the All
control show every label: `getAxisType` produces `AxisType.Time` for a temporal
column, while ECharts applies `axisLabel.interval` only to category axes. The
new regression test only asserts the option value, so it passes without
exercising the reported behavior. Could this control be implemented for time
axes (and covered with a temporal-axis rendering/label test), or limited to the
categorical path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
