rusackas commented on PR #42404: URL: https://github.com/apache/superset/pull/42404#issuecomment-5545830837
@sadpandajoe the feature side of this looks good to me, but one thing before I approve. Looks like `83889c484f` reverted a bunch of `.github/workflows` files to get past the push-token scope issue, and the later merges from `master` kept the old versions. So the diff is still rolling back ~20 workflow files (action pins, the `ubuntu-slim` runners, and the liccheck `pkg_resources` shim, which is why `python-dependency-liccheck` is failing). A `git checkout origin/master -- .github` should sort it now that the token thing's resolved. Also, `UPDATING.md` says themes were admin-only before, but Alpha already had `can_write` via `GAMMA_READ_ONLY_MODEL_VIEWS`... this PR actually tightens that to editors-or-admin, which is probably the thing worth saying there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
