sadpandajoe commented on code in PR #42404:
URL: https://github.com/apache/superset/pull/42404#discussion_r3940807999
##########
superset/themes/api.py:
##########
@@ -149,11 +164,37 @@ class ThemeRestApi(BaseSupersetModelRestApi):
related_field_filters = {
"changed_by": RelatedFieldFilter("first_name", FilterRelatedUsers),
+ "editors": RelatedFieldFilter("label", FilterRelatedSubjects),
Review Comment:
The new Theme editor picker receives the base related-field serialization,
so it returns raw `Subject<…>` text with no `extra.type` or `active` fields;
users lose the normal labels/icons and inactive subjects can be selectable.
Could this add the same `text_field_rel_fields`, `extra_fields_rel_fields`, and
ordering entries used by dashboard/report editors, plus a response-shape test?
##########
superset/migrations/versions/2026-09-04_19-03_aa5fa339627c_merge_add_theme_editors_table_with_.py:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""merge add_theme_editors_table with
retire_semantic_layer_views_connections_pvms
+
+Revision ID: aa5fa339627c
+Revises: ('f7e8d9c0b1a2', 'b3e9c1a75d24')
+Create Date: 2026-09-04 19:03:00.000000
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "aa5fa339627c"
+down_revision = ("f7e8d9c0b1a2", "b3e9c1a75d24")
Review Comment:
This merge still joins `f7e8d9c0b1a2` to `b3e9c1a75d24`, but current master
has added another child from that revision, leaving two Alembic heads when this
PR is merged. `superset db upgrade` then fails before creating `theme_editors`.
Could this merge revision be regenerated against the current master head?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
