sadpandajoe commented on code in PR #43758:
URL: https://github.com/apache/superset/pull/43758#discussion_r3946865281
##########
superset/models/helpers.py:
##########
@@ -5335,6 +5499,11 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
# col_obj is None and sqla_col is None - column not found!
# Silently skip - this can happen for removed columns or
invalid filters
pass
+ if partition_mapping is not None:
Review Comment:
This can silently remove rows whenever a mapped Hive or Impala column has a
supported NULL/special partition: the original filter can match the row, but
the appended partition comparison cannot. Should mappings reject that case or
preserve those rows before adding this predicate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
