bito-code-review[bot] commented on PR #43758: URL: https://github.com/apache/superset/pull/43758#issuecomment-5565647586
<!-- Bito Reply --> The current implementation is designed to be defensive, prioritizing query correctness over aggressive pruning. When a partition mapping is active, the system evaluates the transform and appends the mirrored predicate. If the evaluation fails or returns unexpected results, the system defaults to skipping the mirroring entirely, which ensures that rows are not silently dropped due to mapping inaccuracies. This approach accepts a performance trade-off (scanning more partitions) to maintain data integrity, rather than attempting to preserve rows through complex logic that could introduce its own risks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
