sadpandajoe commented on code in PR #43758:
URL: https://github.com/apache/superset/pull/43758#discussion_r3946874912
##########
superset/models/helpers.py:
##########
@@ -5327,6 +5484,13 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
)
if _temporal_filter is not None:
target_clause_list.append(_temporal_filter)
+ self._collect_partition_mirror_range(
Review Comment:
This mirrors the raw range even when the real predicate uses `flt_grain` and
filters a truncated timestamp expression. For a weekly upper bound, rows later
in the final week still match `DATE_TRUNC(...) < until` but the raw partition
predicate excludes them. Should grain-bearing filters skip mirroring (or use
bounds that preserve the truncated predicate)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
