gkneighb commented on PR #43572: URL: https://github.com/apache/superset/pull/43572#issuecomment-5590551068
@aminghadersohi — thanks for reverting the maintainer-authored changes (`a8711e0` reverting `66c27e0`) to hand the branch back clean; I've now pushed the contributor-authored version. `19a14c2` is bubble rebased onto current master (post the gauge plugin merge), as a single clean commit with your round-2 review addressed: - `entity`/`series` reject `aggregate` (and `saved_metric`/`sql_expression`) via `ColumnRef.is_metric`. - `resolve_metrics` folds `x`/`y`/`size` into query metrics for `bubble_v2` (not just legacy `bubble`), so the MCP query path no longer drops them — covered by a query-context test. - `bubble_v2` added to the `get_chart_type_schema` docstring's core-type list for discoverability, matching the pattern from the gauge review. No maintainer-authored changes remain on the branch. Ready for another look when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
