gkneighb commented on PR #43572: URL: https://github.com/apache/superset/pull/43572#issuecomment-5633740835
@gabotorresruiz Thanks — both of your items are fixed at head `13a0590c`, and the blocking one was exactly as you described. ## 1. Scalar `y` crashes the shared analyzers (blocking) — fixed You were right that this hides behind the compile failure, and right about the consequence: with `save_chart=True` the row is created before the crash, so the caller gets an orphaned chart and no URL. `BubbleChartConfig` is the first member of the union whose `y` is a single `ColumnRef`, and both analyzers duck-typed it as a list — `analyze_chart_capabilities` on `len(config.y)`, `analyze_chart_semantics` on the pydantic `__iter__` yielding `(field, value)` tuples. Fixed in `chart_utils.py` with a small `_as_column_list()` that accepts either shape, applied at both call sites. Driving the analyzers directly against a bubble config at this head: ``` capabilities.data_types: ['metric'] semantics.data_story: This bubble_v2 chart analyzes gdp, life_expectancy ``` Regression tests: `TestBubbleChartAnalyzers` (both written first and watched fail with the `TypeError` / `AttributeError` you reported). ## 2. LLM-facing enumerations (not a blocker) — fixed `generate_chart`'s docstring now carries bubble in all three places — the `chart_type` one-of list, a per-type entry with its required fields, and the `"bubble" / "bubble chart" -> chart_type='bubble_v2'` quick-lookup — and `app.py` has both the "Chart Types You Can CREATE" bullet and `bubble_v2` in the registry-known list. The PR description's end-to-end example said the unsupported `chart_type="bubble"`; that's corrected to `bubble_v2` too. The branch is also rebased onto current master, which resolves the conflict the treemap merge introduced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
