aminghadersohi commented on PR #43572: URL: https://github.com/apache/superset/pull/43572#issuecomment-5620514566
Rechecked author head **19a14c271926**. The dimension-aggregate rejection, Bubble metric/grouping resolution, and schema discovery work, but material gaps remain: - **Creation still has two failure points.** In [the compile path](https://github.com/apache/superset/blob/19a14c2719269329baa7ec8b47e83c8e23fdde8d/superset/mcp_service/chart/compile.py#L125-L148), the example Bubble form-data extracts `columns=[]`, `metrics=[]`; it does not use the corrected Bubble resolver. The preview query path repeats that extraction. Separately, exercising the actual `generate_chart` body with successful compilation and mocked persistence reproduces `TypeError: object of type 'ColumnRef' has no len()` in both preview/save modes; save mode has already called `CreateChartCommand.run()`. The [shared analyzers](https://github.com/apache/superset/blob/19a14c2719269329baa7ec8b47e83c8e23fdde8d/superset/mcp_service/chart/chart_utils.py#L1750-L1840) still assume list-valued `y` (semantics also raises `AttributeError`). Fixing compilation alone therefore leaves the unreported-saved-chart risk. - **CI is genuinely red:** [Python-Unit](https://github.com/apache/superset/actions/runs/34267357903/job/102200184895) reports **1 failed, 14631 passed**. The failure is `test_bubble_in_recommendation_category_map`: `_VIZ_CATEGORY.get("bubble_v2")` returns `None`, not `"bubble"`. The required aggregate check fails too. The isolated Bubble tests reproduce **20 passed / 1 failed**; the old extra-field complaint is not a current failure. - **Validation:** `x={"name":"country"}` against a VARCHAR column passes dataset validation, then maps to `SUM(country)`; explicitly requesting that same SUM is rejected. The implicit aggregate needs equivalent validation. - **Fidelity:** a saved Bubble `orderby=[size]`, descending, with `row_limit=1` loses ordering in `build_query_dicts_from_form_data`. Supplied Bubble result rows produce a Vega-Lite `bar` spec without x/y/size encoding. Update builders also disagree: preview retains existing series/axis options/filters, while immediate-save replacement drops them; omitted color scheme/row limit reset in both. These shared-path limitations prevent a faithful native-chart round trip, even though not all originate in this diff. - **Discovery docs:** `get_chart_type_schema("bubble_v2")` works, but `generate_chart` and `app.py` still omit Bubble; the PR example still says unsupported `chart_type="bubble"`. These were read-only source/unit-harness checks, not a live database/browser run; no charts or contributor code were changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
