rusackas commented on PR #43238: URL: https://github.com/apache/superset/pull/43238#issuecomment-5594108574
One thing before I approve: @sadpandajoe's point about the multi-metric offset fix not being exercised through `transformProps` is still open. It's the same class of bug that needed the copy-paste fix, so I'd feel better with a two-metric, two-groupby case backing the transformProps path before this merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
