viharnani commented on PR #43238: URL: https://github.com/apache/superset/pull/43238#issuecomment-5608519286
> One thing before I approve: @sadpandajoe's point about the multi-metric offset fix not being exercised through `transformProps` is still open. It's the same class of bug that needed the copy-paste fix, so I'd feel better with a two-metric, two-groupby case backing the transformProps path before this merges. @rusackas @sadpandajoe I have added the unit test in transformProps.test.ts with a 2-metric, 2-groupby scenario asserting that stackDimension correctly assigns the matching stack and computes the per-group total labels through transformProps. Regarding the label positioning running into the column, that is existing ECharts label behavior which users can adjust in chart customize controls; I've kept this PR scoped to the stack group calculation bug. Ready for your review . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
