rusackas commented on PR #40679: URL: https://github.com/apache/superset/pull/40679#issuecomment-5594393018
@alex-poor thanks for keeping this current, LGTM on the code side. Every review thread is resolved and the diff is still just the SIP-161 surface (the hook, the batch hook, the `i18n` macro, and the two dump-only fields), so nothing left from me there. The `hold:sip!` label is the only thing in the way. The [VOTE] thread on the `dev@` mailing list is still open with a few +1s and no [RESULT] yet, so this sits until that closes and the hold comes off. Holler if CI turns up anything after the push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
