sadpandajoe commented on code in PR #43020:
URL: https://github.com/apache/superset/pull/43020#discussion_r3964454493
##########
superset/db_engine_specs/lib.py:
##########
@@ -169,7 +165,7 @@ def diagnose(spec: type[BaseEngineSpec]) -> dict[str, Any]:
"query_cost_estimation": has_custom_method(spec,
"estimate_query_cost")
or has_custom_method(spec, "estimate_statement_cost"),
# SQL validation is implemented in external classes
- "sql_validation": spec.engine in sql_validators,
+ "sql_validation": spec.engine in SQL_VALIDATION_ENGINES,
Review Comment:
The generated engine-spec README is now stale: its Aurora PostgreSQL Data
API row still advertises SQL validation and a 104 score, even though this
change makes `diagnose()` report `False` and 94. Could you regenerate the
tables so the checked-in capability matrix matches the removed validator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
