sha174n commented on PR #43020:
URL: https://github.com/apache/superset/pull/43020#issuecomment-5664716147
@rusackas One small follow-up in 2f406d1: the docs generator now uses a
membership test (`engine_attr in {'presto'}`) so it matches the shape of
`SQL_VALIDATION_ENGINES` in `lib.py`, which keeps the "keep the three in sync"
note mechanical. No behaviour change.
Rechecked against current master, no conflicts. Everything from your earlier
passes (UPDATING.md, pgsanity, libecpg-dev, both bito nits, the sql_json_flow
wiring) is in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
