sha174n commented on PR #43020: URL: https://github.com/apache/superset/pull/43020#issuecomment-5662091294
@rusackas Merged current master in 928c5194d3, so the conflicts are clear. That pass also fixed the one real CI failure in `test-postgres-presto`: `test_validate_sql_with_jinja_invalid_sql_after_render` still asserted the annotation list the old validator returned, but `PrestoDBSQLValidator` parses the whole script before it can annotate any statement, so SQL it cannot parse comes back as an error response instead. The test now asserts that contract, and still pins the failure to the rendered SQL, which is the thing it guards. No rush on the coverage question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
