AmoghAtreya commented on PR #43176:
URL: https://github.com/apache/superset/pull/43176#issuecomment-5596416474
Thanks again @gabotorresruiz for the thorough review and detailed
instructions on what to fix and @rusackas for following up. Sorry for the delay
, but the blocking items from the last review are in.
Here's what I fixed:
1) OAuth `form_data_key` stub now returns `SimpleNamespace(queries=[],
form_data={}) so _query_from_form_data` doesn’t blow up
2) mypy casts / ruff-format on the helper tests
3) rebased/merged onto master, keeping `datasource_id: int | str`
4) saved SQL / chart-data Jinja fallback now prefers the executed
`query_context` datasource (with JSON, then chart, as a fallback so MagicMock
doubles still work)
CI is green on the latest commits. The `get_time_filter()` no-column /
`TEMPORAL_RANGE`-only note matches what I see as well — same as the chart-data
API, so executed and displayed SQL stay in sync.
Please let me know if there's any other changes you would like me to
implement. Happy to follow up on anything else!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
