rusackas commented on PR #43176: URL: https://github.com/apache/superset/pull/43176#issuecomment-5684660888
@AmoghAtreya still conflicting with `master`, and the commits since your reply didn't touch the rebase, `test_compile.py`, `test_preview_utils.py`, and `test_get_table.py` are still the ones to resolve. Also, bito's one-sided-range note on `tabular_query.py` seems right: get_table's `rewrite_one_sided_time_range` path emits GTE/LT filters instead of TEMPORAL_RANGE, so `_time_range_from_filters` can't hoist it and Jinja loses the range for semantic views on that path. Worth a fix before this lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
