rusackas commented on code in PR #43176:
URL: https://github.com/apache/superset/pull/43176#discussion_r4018369834
##########
superset/mcp_service/chart/tool/get_chart_sql.py:
##########
@@ -185,6 +187,11 @@ def _sql_from_saved_query_context(
query_context = ChartDataQueryContextSchema().load(qc_json)
query_context.result_type = ChartDataResultType.QUERY
+ set_query_context_form_data(
+ query_context,
+ chart.datasource_id,
+ chart.datasource_type,
+ )
Review Comment:
I think this is covered too, just less directly. `_serialize_query` still
carries `query.filter` up as `filters`, and `get_time_filter()` runs
`convert_legacy_filters_into_adhoc()` first, converting any `TEMPORAL_RANGE`
entries into `adhoc_filters` before matching on column. No test covers the
column-specific case though, so flagging before closing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
