bito-code-review[bot] commented on PR #44123:
URL: https://github.com/apache/superset/pull/44123#issuecomment-5610878902
<!-- Bito Reply -->
The flagged issue is correct. Using `contains(join(...), '🎪 ')` performs a
substring match, which incorrectly triggers the job if any label contains the
string '🎪 ' (e.g., 'needs 🎪 review'). To resolve this, you should check for the
exact label name or use a more precise matching strategy, such as checking if
the label list contains the specific label '🎪 Showtime'.
Here is the corrected condition:
```yaml
(github.event.action == 'synchronize' ||
github.event.action == 'closed') &&
contains(github.event.pull_request.labels.*.name, '🎪 Showtime')
```
There are no other comments on this PR. Would you like me to check for any
other potential issues in this file?
**.github/workflows/showtime-trigger.yml**
```
(github.event.action == 'synchronize' ||
github.event.action == 'closed') &&
contains(github.event.pull_request.labels.*.name, '🎪 Showtime')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
