codeant-ai-for-open-source[bot] commented on code in PR #44123:
URL: https://github.com/apache/superset/pull/44123#discussion_r3974392536
##########
.github/workflows/showtime-trigger.yml:
##########
@@ -32,6 +32,15 @@ permissions:
jobs:
sync:
name: ๐ช Sync PR to desired state
+ # Inspect the changed label so removing the last Showtime label still
syncs.
+ if: >-
+ github.event_name == 'workflow_dispatch' ||
+ startsWith(github.event.label.name, '๐ช ') ||
+ (
+ (github.event.action == 'synchronize' ||
+ github.event.action == 'closed') &&
+ contains(join(github.event.pull_request.labels.*.name, ','), '๐ช ')
Review Comment:
**Suggestion:** The joined-label substring check matches unrelated labels
such as `needs ๐ช review`, so synchronize or closed events run the Showtime job
unexpectedly. [incorrect condition logic]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7333b3a829a347118a32cb96b94ae7bb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7333b3a829a347118a32cb96b94ae7bb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .github/workflows/showtime-trigger.yml
**Line:** 40:42
**Comment:**
*Incorrect Condition Logic: The joined-label substring check matches
unrelated labels such as `needs ๐ช review`, so synchronize or closed events run
the Showtime job unexpectedly.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44123&comment_hash=88948f36bb68c061d6b7a4f2b9156e21cb0493d7b809ace36311efd0127af077&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44123&comment_hash=88948f36bb68c061d6b7a4f2b9156e21cb0493d7b809ace36311efd0127af077&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
