rusackas commented on code in PR #44123:
URL: https://github.com/apache/superset/pull/44123#discussion_r3974710498
##########
.github/workflows/showtime-trigger.yml:
##########
@@ -32,6 +32,15 @@ permissions:
jobs:
sync:
name: 🎪 Sync PR to desired state
+ # Inspect the changed label so removing the last Showtime label still
syncs.
+ if: >-
+ github.event_name == 'workflow_dispatch' ||
+ startsWith(github.event.label.name, '🎪 ') ||
+ (
+ (github.event.action == 'synchronize' ||
+ github.event.action == 'closed') &&
+ contains(join(github.event.pull_request.labels.*.name, ','), '🎪 ')
Review Comment:
Good catch, this was real. Swapped `contains(join(labels, ',' ), '🎪 ')` for
`contains(toJson(labels), "\"🎪 ")` so it only matches when a label actually
starts with 🎪, not anywhere in the joined string. Pushed to the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
