FrancescoCastaldi commented on PR #39724: URL: https://github.com/apache/superset/pull/39724#issuecomment-5621724268
Follow-up update in commit 0b27f4bfda2: - On Windows, formatted the command string directly with `_format_cmd_arg` instead of passing pre-quoted args in a list, preventing Python's `subprocess.list2cmdline` from double-escaping quotes into `\"...\"` when batch wrappers (`.cmd`) are executed, while fully safeguarding against command operator injection (`&`, `|`, etc.). - Replaced the dictionary comprehension in `ThreadPoolExecutor` with a list comprehension to remove the unused future value. - Added comprehensive unit tests in `compile_po_test.py` covering `_format_cmd_arg` and Windows command line formatting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
