FrancescoCastaldi commented on PR #39724: URL: https://github.com/apache/superset/pull/39724#issuecomment-5640763005
Follow-up update in commit 05073aa8eab addressing review feedback & runtime verification: - **oxfmt argument fix**: Replaced unsupported `--no-ignore` with `--no-error-on-unmatched-pattern`. Runtime verification confirmed `oxfmt` does not support `--no-ignore` (exits non-zero with `Error: --no-ignore is not expected in this context`), whereas `--no-error-on-unmatched-pattern` actively formats all 30 generated `messages.json` files in 436ms without errors. - **Windows CLI argument escaping**: Enhanced `_format_cmd_arg` to double sequences of backslashes preceding quotes (including trailing backslashes on quoted directories) and double embedded quotes per Windows CRT / `CommandLineToArgvW` rules, eliminating argument corruption or swallowing on paths ending in `\`. - **Executable binary discovery**: Updated `find_node_bin` on Windows to check `.cmd`, `.bat`, `.exe` and omitted `.ps1` (which cannot be launched directly via `CreateProcessW` with `shell=False`). - **Test suite**: All 23 unit tests, ruff linting, and ruff format pass cleanly, and the full pipeline was validated end-to-end on Windows. /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
