FrancescoCastaldi commented on PR #39724: URL: https://github.com/apache/superset/pull/39724#issuecomment-5640607597
Follow-up update in commit caae4b51464 addressing review feedback: - Updated `_format_cmd_arg` in `scripts/compile_po.py` to escape embedded quotes by doubling them (`""`) instead of backslash-escaping (`\"`), matching `cmd.exe` quoting conventions and ensuring filenames with embedded quotes survive intact when executing batch wrappers on Windows. - Updated `test_format_cmd_arg` and `test_run_command_quotes_cmd_metacharacters` in `tests/unit_tests/scripts/translations/compile_po_test.py` to assert the expected doubled quotes (`""`). - All 22 unit tests and ruff linting/formatting pass cleanly. /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
