codeant-ai-for-open-source[bot] commented on code in PR #44069:
URL: https://github.com/apache/superset/pull/44069#discussion_r3985161388
##########
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx:
##########
@@ -339,6 +339,34 @@ export default function RangeFilterPlugin(props:
PluginFilterRangeProps) {
return;
}
+ // Clear sentinel takes priority over the error revalidation below. The
+ // filter bar stages [null, null] (plus a validateStatus of 'error' for
+ // required filters) when a parent filter changes or Clear All is
+ // triggered. Re-validating the stale local inputValue in that case would
+ // re-emit the previously selected range, defeating the clear.
+ if (
+ filterState.value === undefined ||
+ isEqualArray(filterState.value, [null, null])
+ ) {
+ setInputValue([null, null]);
Review Comment:
**Suggestion:** Initial `undefined` state is treated as a clear, so ranges
with a configured `defaultValue` are reset to `[null, null]` instead of
applying that default. [logic error]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=39f5295b76a9410bb864a7912de3b72c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=39f5295b76a9410bb864a7912de3b72c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx
**Line:** 347:351
**Comment:**
*Logic Error: Initial `undefined` state is treated as a clear, so
ranges with a configured `defaultValue` are reset to `[null, null]` instead of
applying that default.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44069&comment_hash=b6b97b0692957cf299aed773983fd3119f14e63f1d8135fcc70123a3cb61e0d9&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44069&comment_hash=b6b97b0692957cf299aed773983fd3119f14e63f1d8135fcc70123a3cb61e0d9&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
