codeant-ai-for-open-source[bot] commented on code in PR #44069:
URL: https://github.com/apache/superset/pull/44069#discussion_r3985163109
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -513,6 +515,27 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
}
}, [clearAllTrigger, onClearAllComplete, updateDataMask]);
+ useEffect(() => {
+ // When a parent filter's value changes, a cascading clear signals this
+ // dependent filter to reset its visual selection. Same behavior as a
+ // global clear-all but scoped to one descendant.
+ if (cascadeClearTrigger) {
+ dispatchDataMask({
+ type: 'filterState',
+ extraFormData: {},
+ filterState: {
+ value: undefined,
+ label: undefined,
+ },
+ });
+
+ updateDataMask(null);
Review Comment:
**Suggestion:** For required non-inverse filters, `updateDataMask(null)`
rebuilds `extraFormData` with `1 = 0`, overwriting the staged empty mask and
leaving cleared children filtering out every row. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=14a8dae638e04132a4866eddd49ede57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=14a8dae638e04132a4866eddd49ede57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
**Line:** 532:532
**Comment:**
*Api Mismatch: For required non-inverse filters, `updateDataMask(null)`
rebuilds `extraFormData` with `1 = 0`, overwriting the staged empty mask and
leaving cleared children filtering out every row.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44069&comment_hash=13b410748a07abacd366221df916b6145c39f4263677c24063c1eea71125313a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44069&comment_hash=13b410748a07abacd366221df916b6145c39f4263677c24063c1eea71125313a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
