aminghadersohi commented on PR #44152: URL: https://github.com/apache/superset/pull/44152#issuecomment-5628377426
## Finite follow-up complete — required CI green Exact head: **6a4748070da3e18f8ffe41c1e11363074bb4c03e**. Normal pushes only; no draft, force-push or PR merge. Commits: - 6d2a824812279fc48146e38cf21fc04fd3007310 — normal merge of upstream master 89565db. - b7024009d5c3a0ed7145f2047d54d184d8e3cd94 — shared 40-minute workflow budget, nullable preview format, structured update errors, cached schema compilation and review regressions. - 6a4748070da3e18f8ffe41c1e11363074bb4c03e — selected Treemap temporal column reaches query granularity; override/clear and mixed-type grouping regressions. [Exact-head checks](https://github.com/apache/superset/pull/44152/checks): **all 13 required checks passed**; overall **64 success, 10 skipped, 3 neutral**, no pending or failed checks. [Python-Unit](https://github.com/apache/superset/actions/runs/34550891815) finished successfully in **31m27s**: - Main suite: **15,248 passed, 7 skipped, 2 xfailed**. - SQL: **1,717 passed / 100% coverage**. - Semantic layers: **437 passed / 100% coverage**. - Coverage upload and JUnit artifact upload passed. No tests, coverage thresholds or required-gate enforcement were reduced. Final-head local evidence: - Full MCP/common: **4,430 passed, 1 skipped**, 335.34s. The skip is the absent optional BigQuery dependency. - Real Vega 5.33.1 / Vega-Lite 5.23.0 renderer exercised both null and explicit formats, with scenegraph geometry/labels/tooltips assertions. CI does not install this optional Node renderer; both cases were exercised locally. - SQL **1,717 / 100%**, semantic layers **437 / 100%**. - Full branch-file pre-commit passed (MyPy, Ruff, Pylint, formatting and workflow audit); compile and diff checks passed. - Eight strengthened review cases failed on the previous implementation; selected-time-column queries also reproduced the late temporal finding before the fix. Regression/evidence replies are attached to all three inline review findings. PR remains Amin-authored/assigned, non-draft and conflict-free (MERGEABLE). GitHub still reports REVIEW_REQUIRED; human approval remains necessary. Worktree is clean. No live Superset/browser/database environment was available locally; product-path unit tests mock execution/persistence, while exact-head integration/browser CI passed. No additional review/retry loop was started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
