AmoghAtreya commented on PR #43176: URL: https://github.com/apache/superset/pull/43176#issuecomment-5702768408
Thanks @gabotorresruiz — the hoist-from-processed-filters claim didn’t actually hold, and your `cache_values` catch was the right fix. `_apply_granularity` deletes the `TEMPORAL_RANGE` filter on the granularity column before `set_query_context_form_data` runs, so Jinja was seeing `No filter`. The helper now falls back to the raw pre-processing query dicts on `query_context.cache_values["queries"]`. One-sided semantic-view `>=` / `<` rewrites are reconstructed too. `QueryObject.time_range` stays unset, so the cache-key/rollover fix is unchanged. `test_query_dataset_exposes_filters_to_jinja_macros` and the matching `get_table` test now patch `QueryContextFactory._convert_to_model` instead of `create`, so they actually run `_apply_granularity`. They assert the processed filters no longer contain `TEMPORAL_RANGE` and that `get_time_filter()` still returns `Last week`. Rebased onto latest master. Please let me know if there's anything else to change! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
