sadpandajoe commented on code in PR #42760:
URL: https://github.com/apache/superset/pull/42760#discussion_r4032766327
##########
superset-frontend/src/explore/components/ChartPills.tsx:
##########
@@ -100,11 +112,20 @@ export const ChartPills = forwardRef(
limit={Number(rowLimit ?? 0)}
/>
)}
- {!isLoading && firstQueryResponse?.is_cached && (
- <CachedLabel
- onClick={refreshCachedQuery}
- cachedTimestamp={firstQueryResponse.cached_dttm}
- />
+ {!isLoading &&
+ semanticCacheStatus !== 'MIXED' &&
+ (firstQueryResponse?.is_cached ||
+ semanticCacheStatus === 'HIT') && (
+ <CachedLabel
+ onClick={refreshCachedQuery}
+ cachedTimestamp={firstQueryResponse?.cached_dttm}
+ cacheSource={
+ semanticCacheStatus === 'HIT' ? 'semantic' : 'result'
+ }
+ />
+ )}
+ {!isLoading && semanticCacheStatus === 'MIXED' && (
Review Comment:
For a server-paginated table, the row-count query is intentionally a
containment miss while the data query can be a hit. That makes this branch the
steady state and removes Explore's only force-refresh affordance. Could the
mixed indicator retain the cache pill's refresh action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
