sadpandajoe commented on code in PR #42760:
URL: https://github.com/apache/superset/pull/42760#discussion_r4033088933
##########
superset/coordination/cache_backend.py:
##########
@@ -280,12 +346,14 @@ def __init__( # pylint: disable=too-many-arguments
ssl_ca_certs: str | None = None,
socket_timeout: float | None = None,
socket_connect_timeout: float | None = None,
+ force_master_ip: str | None = None,
**kwargs: Any,
) -> None:
# Sentinel dont directly support SSL
# Initialize Sentinel without SSL parameters
self._sentinel = Sentinel(
sentinels,
+ force_master_ip=force_master_ip,
Review Comment:
This passes `force_master_ip` even when it is `None`, but our supported
`redis>=5.0.0` range includes redis-py 5.0, whose `Sentinel` constructor
forwards that unknown kwarg into connection setup. Sentinel-backed coordination
then fails on its first cache operation instead of retaining the prior
behavior. Could this omit the kwarg when unset (or raise the minimum redis-py
version)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
