mikebridge commented on PR #42760: URL: https://github.com/apache/superset/pull/42760#issuecomment-5724739463
Updated in two separate commits for review: master re-sync `75e44b557d6ec531693a045eb46cd9d6ab38b8b3`, then correctness fix `65971b967a12e8c34b3f68f6ff2c5f9c62bdbdfc`. The review found a monthly cached result could incorrectly answer a partial-month range. The fix rejects narrowing on a cached grained axis, including its raw-column variant; regressions cover partial upper/lower bounds and preserve safe raw-axis containment. Independent re-review approved the fix. Final local verification: 676 semantic-layer tests pass with 100% statement/branch coverage, and the focused changed-file hooks pass. The update also repairs the generated OpenAPI property, unused MyPy ignore and coverage gaps. Docs clarify binary/codepoint collation assumptions and that atomic fencing is a same-client optimisation; default deployments use the non-atomic immediate ownership recheck. Mapper variant ordering remains a separate [SC-121337](https://app.shortcut.com/preset/story/121337) follow-up. Remaining non-blocking follow-ups are disclosed in the PR body. `hold!` stays. This is publication for validation, not a merge request: we still need green CI on this exact head, including Redis/Sentinel `test-semantic-cache-coordination` and frontend compilation, plus a flag-on soak with a real opted-in provider exercising concurrent forced refreshes and narrowed ranges against direct-provider answers. Local frontend checking was limited by unbuilt workspace declarations (TS6305); no frontend build or live-provider/Redis soak is claimed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
