mikebridge commented on code in PR #44009:
URL: https://github.com/apache/superset/pull/44009#discussion_r4033213896
##########
superset/versioning/metrics.py:
##########
@@ -52,3 +52,37 @@ def incr_capture_error(stage: str) -> None:
stats_logger_manager.instance.incr(f"{_CAPTURE_METRIC_PREFIX}.{stage}.error")
except Exception: # pylint: disable=broad-except
logger.exception("versioning: failed to emit capture-error metric")
+
+
+def emit_capture_timing(stage: str, duration_ms: float) -> None:
+ """Emit the write-path latency for one capture *stage*, in milliseconds.
+
+ The documented recovery lever for capture trouble is the
+ ``ENABLE_VERSIONING_CAPTURE`` kill-switch, flipped on save-path
+ slowdown — the ``superset.versioning.capture.<stage>.latency`` series
Review Comment:
Thanks for separating this from the blocking fixes. I verified that the
published StatsdStatsLogger supplies the default `superset` prefix and this
module still supplies `superset.versioning.capture.*`; the effective default
StatsD name therefore includes the repeated namespace. Could we keep the
existing names stable in this PR and handle the coordinated
capture/retention/activity namespace change in the follow-up you offered,
including compatibility/alert migration guidance? No rename is included in
`d6e3d4f11007e3cb0cdbc6a8d8fb7d7660ef2dba`, and no assumption is made about
whether operators already have alerts. The three blocking fixes are linked
individually above; this remains an explicitly deferred, nonblocking
instrumentation issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
