mikebridge commented on code in PR #44265:
URL: https://github.com/apache/superset/pull/44265#discussion_r4041158952
##########
superset/mcp_service/semantic_layer/tool/get_table.py:
##########
@@ -322,6 +326,27 @@ async def _run_get_table_query(
error_type="ValidationError",
)
+ if (
+ not is_builtin
+ and resolved.view is not None
+ and request.metrics
+ and request.dimensions
Review Comment:
Addressed in e57564e — `filters[].col` values are now folded into the
required-dimension set, so a filter-only dimension goes through the same
metric-compatibility check as the requested dimensions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
