aminghadersohi commented on code in PR #44265:
URL: https://github.com/apache/superset/pull/44265#discussion_r4045208084
##########
superset/mcp_service/semantic_layer/tool/get_table.py:
##########
@@ -322,6 +333,32 @@ async def _run_get_table_query(
error_type="ValidationError",
)
+ required_dimensions: set[str] = (
+ set(request.dimensions)
+ | {query_filter.col for query_filter in request.filters}
+ | (set(request.order_by) & resolved.valid_columns)
+ ) - resolved.temporal_columns
Review Comment:
Widening this to all temporal columns was our earlier ask, so bito's
counter-suggestion to narrow back to TEMPORAL_RANGE-only would restore the
inconsistency we filed: `dimensions=['order_ts']` rejected while
`time_column`+`time_range` passed. Keep it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
