mikebridge commented on code in PR #44265:
URL: https://github.com/apache/superset/pull/44265#discussion_r4041219083
##########
superset/mcp_service/semantic_layer/tool/get_table.py:
##########
@@ -322,6 +326,30 @@ async def _run_get_table_query(
error_type="ValidationError",
)
+ required_dimensions: set[str] = set(request.dimensions) | {
+ query_filter.col for query_filter in request.filters
+ }
Review Comment:
addressed in 0c5f7f2f93d7036a8fc6b76bec69ab221f3abda3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
