bito-code-review[bot] commented on PR #44490:
URL: https://github.com/apache/superset/pull/44490#issuecomment-5757122132
<!-- Bito Reply -->
The flagged issue is incorrect. The PR introduces a portal-based approach
(`InPortal`/`OutPortal`) to manage the chat panel's mounting state across
display modes. In the updated `AppContent` component, the `ChatPanelHost` is
rendered inside an `InPortal` when `panelOpen` is true, and the `OutPortal` is
placed within `ChatFloatingHost` when in floating mode. This ensures the chat
panel remains mounted and its state is preserved even when switching modes,
effectively resolving the concern about the trigger being lost.
**superset-frontend/src/views/App.tsx**
```
{hasChatExtension && panelOpen && (
<InPortal node={chatPortalNode}>
<ChatPanelHost />
</InPortal>
)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
