bito-code-review[bot] commented on code in PR #44490:
URL: https://github.com/apache/superset/pull/44490#discussion_r4060208212
##########
superset-frontend/src/core/chat/ChatHost.tsx:
##########
@@ -116,13 +116,15 @@ export const ChatFloatingHost = () => {
Separate boundaries so a crashing panel cannot take the trigger down
with it — the trigger is the user's only way back.
*/}
- {panelOpen && mode !== 'panel' && (
- <ChatBoundary
- key={`panel-${chat.id}`}
- component={panel}
- onError={onError}
- />
- )}
+ {panelOpen &&
+ mode !== 'panel' &&
+ (children ?? (
+ <ChatBoundary
+ key={`panel-${chat.id}`}
+ component={panel}
+ onError={onError}
+ />
+ ))}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Untested children override branch</b></div>
<div id="fix">
The new `children` override is the primary production path —
`App.tsx:235-237` always wraps `<OutPortal>` — yet `ChatHost.test.tsx`, the
only suite rendering `ChatFloatingHost`, never passes children (verified: zero
`children` occurrences), so this branch and its interaction with
`panelOpen`/`mode` ships untested while the tested fallback is test-only.
</div>
</div>
<small><i>Code Review Run #d8002e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
