bito-code-review[bot] commented on code in PR #44490:
URL: https://github.com/apache/superset/pull/44490#discussion_r4060247075
##########
superset-frontend/src/core/chat/ChatHost.tsx:
##########
@@ -116,13 +116,15 @@ export const ChatFloatingHost = () => {
Separate boundaries so a crashing panel cannot take the trigger down
with it — the trigger is the user's only way back.
*/}
- {panelOpen && mode !== 'panel' && (
- <ChatBoundary
- key={`panel-${chat.id}`}
- component={panel}
- onError={onError}
- />
- )}
+ {panelOpen &&
+ mode !== 'panel' &&
+ (children ?? (
+ <ChatBoundary
+ key={`panel-${chat.id}`}
+ component={panel}
+ onError={onError}
+ />
+ ))}
Review Comment:
<!-- Bito Reply -->
The explanation provided clarifies that the `children` override branch is
indeed covered by the `src/views/App.test.tsx` suite, which renders the real
components and exercises the relevant logic. Given that the existing regression
test in `ChatHost.test.tsx` effectively covers the standalone behavior and the
new test suite handles the app-level branch, the current testing strategy is
sufficient to verify the fix and prevent regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
