codeant-ai-for-open-source[bot] commented on code in PR #44500:
URL: https://github.com/apache/superset/pull/44500#discussion_r4062024075
##########
superset/utils/core.py:
##########
@@ -2046,7 +2047,7 @@ def _process_datetime_column(
col: DateColumn,
) -> None:
"""Process a single datetime column with format detection."""
- if col.timestamp_format in ("epoch_s", "epoch_ms"):
+ if col.timestamp_format in EPOCH_FORMATS:
Review Comment:
**Suggestion:** String microsecond epochs enter the already-formatted path
instead of being parsed with unit `us`, producing incorrect timestamps or
leaving the original strings after conversion fails.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Type error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f9b6418982b6478d8a7018bdd1d87980&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f9b6418982b6478d8a7018bdd1d87980&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/core.py
**Line:** 2050:2050
**Comment:**
*Type Error: String microsecond epochs enter the already-formatted path
instead of being parsed with unit `us`, producing incorrect timestamps or
leaving the original strings after conversion fails.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44500&comment_hash=c1d7999012cce34456157646ee36e2d031144f94a648570123d16924db585370&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44500&comment_hash=c1d7999012cce34456157646ee36e2d031144f94a648570123d16924db585370&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
