Copilot commented on code in PR #44500:
URL: https://github.com/apache/superset/pull/44500#discussion_r4064811962
##########
superset/utils/core.py:
##########
@@ -2046,7 +2047,7 @@ def _process_datetime_column(
col: DateColumn,
) -> None:
"""Process a single datetime column with format detection."""
- if col.timestamp_format in ("epoch_s", "epoch_ms"):
+ if col.timestamp_format in EPOCH_FORMATS:
Review Comment:
Adding `epoch_us` to this branch is not sufficient for result normalization:
the conversion logic below still selects seconds for every format other than
`epoch_ms`. Consequently, values such as `1577836800000000` are interpreted as
seconds instead of microseconds and will overflow or produce invalid datetimes.
Derive the pandas unit from the epoch format, including `us`, before calling
`pd.to_datetime`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
