codeant-ai-for-open-source[bot] commented on code in PR #44500:
URL: https://github.com/apache/superset/pull/44500#discussion_r4067894402
##########
superset/connectors/sqla/models.py:
##########
@@ -1295,7 +1296,7 @@ def get_timestamp_expression( # noqa: C901
label = label or utils.DTTM_ALIAS
pdf = self.python_date_format
- is_epoch = pdf in ("epoch_s", "epoch_ms")
+ is_epoch = pdf in EPOCH_FORMATS
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag epoch arithmetic based on the configured epoch date format as
a type error; SQL type mismatches are dataset configuration errors under the
existing contract.
**Applied to:**
- `superset/connectors/sqla/models.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
