sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5761072516
@rusackas you and bito were right — `update_from_object` writes `obj.get(attr)` with no default, so an omitted `table_name`/`schema`/`catalog` lands as `None` and the fallback made that read as unchanged. Dropped the fallback in d16ddd8, with a test for the omitted-key path. Removing the fallback surfaced two cases the stricter comparison would have caught wrongly, fixed in df17cab: a virtual dataset's `table_name` is a label rather than a pointer, so renaming one was getting gated on a physical table that doesn't exist (`UpdateDatasetCommand` skips the check there too, and a database repoint stays checked either way); and `BaseDatasource.data` emits an empty schema as `None`, so a dataset stored with `schema=""` round-tripped as a repoint. Both have regression tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
