sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5769177529
@rusackas right, thanks — a query has `tmp_table_name`, not `table_name`, so reading the pointer unconditionally broke every non-dataset save. Fixed in 5ce70d6: the predicate moved into a `_repoints_table` helper behind an `isinstance(orm_datasource, SqlaTable)` guard, which also narrows the `DatasourceDAO` union so mypy is happy without a cast. Added `test_save_of_non_dataset_datasource_skips_table_check`, specced to a query's attribute surface so touching `table_name`/`is_virtual` raises rather than passing silently — it reproduces the AttributeError without the guard. Same pass drops the `astuple` deepcopy for a plain tuple compare and routes the remaining save tests through the shared `_run_save` helper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
