sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5762814622
@rusackas one more in 96e2c48, from a self-review pass on the same block: the virtual-dataset skip needed a companion clause for the conversion case. Dropping `sql` binds the `table_name` label to a real table, so that save has to run the target-table check even when the label is unchanged, otherwise the label can be renamed under the skip and converted in a second save. `UpdateDatasetCommand._validate_dataset_source` has the equivalent clause; this ports it. Regression test added, and the mocks now set `sql` explicitly since an unset `MagicMock` attribute was making every physical fixture read as virtual. Rest of the commit is cleanup: the source-binding comparison is field-by-field rather than `Table.__eq__` (which compares the dotted rendering, so `table="a.b"` and `schema="a", table="b"` would read as the same target), the current database is only resolved on the branch that needs it instead of lazy-loading a row the repoint path throws away, and the `update_from_object` replace-semantics note moved into its docstring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
