sha174n commented on PR #44496: URL: https://github.com/apache/superset/pull/44496#issuecomment-5770691168
Added in 3d9d7dd: the cost-estimate path (`QueryEstimationCommand._apply_sql_security`) documents itself as mirroring `sql_lab.execute_sql_statements`, but only carried the disallowed-function, disallowed-table and DML gates, so the new check now runs there too and the four controls stay in step. Pinned by a parametrized test over both `allow_dml` values (removing the gate fails all 6). @aminghadersohi no change to the quoted-path handling you flagged, that stands as replied above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
