codeant-ai-for-open-source[bot] commented on code in PR #44496:
URL: https://github.com/apache/superset/pull/44496#discussion_r4068627456
##########
superset/sql/execution/executor.py:
##########
@@ -604,6 +604,19 @@ def _check_security(self, script: SQLScript, schema: str |
None = None) -> None:
)
)
+ # Rejected regardless of `allow_dml`: these do host file I/O, not DML.
+ if file_transfer_commands :=
script.get_client_file_transfer_commands():
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Treat SQL_QUERY_MUTATOR as operator-trusted and do not require security
gates to be re-applied after it runs; keep validation consistent with the other
pre-mutator security checks.
**Applied to:**
- `superset/sql/execution/executor.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
