sha174n commented on PR #44496: URL: https://github.com/apache/superset/pull/44496#issuecomment-5772614328
Pushed 9afeb83, which changes behavior since your approvals, @aminghadersohi @rusackas. `_nested_body_text` was rendering the body node with `str()`, which re-quotes it and doubles the quotes inside, so the raw-text scans were reading text the server never runs. It now reads the value off the literal and strips comments there rather than per caller, so the file-transfer scan and the two sibling scans all classify on code that actually executes. String literals are kept untouched (a nested body runs its dynamic SQL out of one), which also means the strip can only ever remove text that never executes. Two cases pinned: a commented-out head no longer matches, and a body whose own quotes are doubled now does (it was previously skipped). Sibling `changes_search_path`/`changes_default_schema` cases added for the shared accessor. The red checks are `messages.pot` drift inherited from master (master's own translations workflow is failing); this branch touches no translation files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
