sha174n commented on PR #44496: URL: https://github.com/apache/superset/pull/44496#issuecomment-5777345064
@aminghadersohi your `PUT`/`GET` point was already fixed in bc23bd4 (the `exp.Put`/`exp.Get` node match) — nothing outstanding there. Flagging 8ae0fb7 as another behavior change since your approval, same as the last few: - The ordering fix moved up a level. `get_client_file_transfer_commands()` now returns a sorted `list[str]` rather than a `set`, so the three messages built from it no longer each carry their own `sorted()`. The guarantee lives at the producer and a fourth caller cannot forget it. Script test pins the dedup and the order. - Comments are now stripped inside literals, not just around them (details in the comment above). - SingleStore joins the dialects where `--` only opens a comment when whitespace follows. It speaks the MySQL wire protocol and shares its tokenizer, but sqlglot has no `Dialects` member for it, so it was falling through to the loose rule and losing body text after an unspaced `--`. 100% coverage on `superset/sql/` is restored (that was the red check). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
