gabotorresruiz commented on PR #43176:
URL: https://github.com/apache/superset/pull/43176#issuecomment-5780795523

   Not this branch, @rusackas. I checked the result at `d11807b2`.
   
   The Update branch merge did its job on the translations side: `messages.pot` 
now matches master byte for byte, `4c229cb6` is an ancestor, and 
`babel-extract` is green.
   
   What is left is 
`docker_cache_ref_test.py::test_cache_ref_matches_dockerfile_py_ver` for 
`.github/workflows/superset-frontend.yml` and 
`.github/workflows/frontend-bundle-size-nightly.yml`. `Dockerfile` declares 
`ARG PY_VER=3.11-slim-trixie` while both workflows pull 
`apache/superset-cache:3.11.14-slim-trixie`. I ran the test's comparison 
against current master `21db4a5e` and it fails there identically, same two 
files, same values, while the three compose files pass. The branch only 
inherited it by merging master, and this PR touches neither workflow nor the 
`Dockerfile`.
   
   I also re-diffed after the merge: the PR's net change against master is byte 
for byte what it was at `cf1be0c`, so the approval still stands. Nothing to do 
here until master fixes the tag skew, either by bumping the two workflows to 
`3.11-slim-trixie` or by pinning `ARG PY_VER` back to the patch version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to